Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codebase to async/await - todo task get until yammer message add, Closes #5116 #5138

Closed
wants to merge 3 commits into from
Closed

Refactor codebase to async/await - todo task get until yammer message add, Closes #5116 #5138

wants to merge 3 commits into from

Conversation

nicodecleyre
Copy link
Contributor

Closes #5116

@milanholemans
Copy link
Contributor

Thank you, we'll review it ASAP.

@Adam-it
Copy link
Member

Adam-it commented Jul 21, 2023

@nicodecleyre lets rebase and resolve the conflicts before we proceed 👍

@Adam-it Adam-it self-assigned this Jul 21, 2023
@Adam-it Adam-it marked this pull request as draft July 21, 2023 23:42
@nicodecleyre nicodecleyre force-pushed the Refactor-todo-task-get---yammer-message-list branch from 405e4ce to fc1ca01 Compare July 31, 2023 19:46
@nicodecleyre nicodecleyre marked this pull request as ready for review July 31, 2023 19:46
Adam-it
Adam-it requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are on the right track 👍
Let's recheck a couple of details before we merge

src/m365/todo/commands/task/task-remove.ts Outdated Show resolved Hide resolved
src/m365/todo/commands/task/task-remove.ts Outdated Show resolved Hide resolved
src/m365/todo/commands/task/task-remove.ts Outdated Show resolved Hide resolved
src/m365/todo/commands/task/task-set.ts Outdated Show resolved Hide resolved
src/m365/todo/commands/task/task-set.ts Outdated Show resolved Hide resolved
src/m365/yammer/commands/message/message-add.spec.ts Outdated Show resolved Hide resolved
src/m365/yammer/commands/message/message-add.spec.ts Outdated Show resolved Hide resolved
src/m365/yammer/commands/group/group-user-remove.ts Outdated Show resolved Hide resolved
src/m365/yammer/commands/group/group-user-remove.ts Outdated Show resolved Hide resolved
src/m365/yammer/commands/group/group-user-remove.ts Outdated Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft August 15, 2023 22:17
@nicodecleyre nicodecleyre force-pushed the Refactor-todo-task-get---yammer-message-list branch from fc1ca01 to cb5336f Compare September 1, 2023 17:49
@nicodecleyre nicodecleyre marked this pull request as ready for review September 1, 2023 17:56
Adam-it
Adam-it approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked locally ✅
LGTM 👍
one small comment I will resolve it myself when merging

src/m365/todo/commands/task/task-remove.ts
return options.listId as string;
}

private async removeToDoTask(args: CommandArgs): Promise<void> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as best practice we should pass options not args

Suggested change
private async removeToDoTask(args: CommandArgs): Promise<void> {
private async removeToDoTask(options: GlobalOptions): Promise<void> {

@Adam-it
Copy link
Member

Adam-it commented Oct 15, 2023

ready to merge 🚀

@Adam-it Adam-it added pr-merged hacktoberfest-accepted Accept for hacktoberfest, will merge later labels Oct 15, 2023
@Adam-it
Copy link
Member

Adam-it commented Oct 15, 2023

merged manually. Awesome work 👏

@Adam-it Adam-it closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor codebase to async/await - todo task get until yammer message add
3 participants
@nicodecleyre @milanholemans @Adam-it